-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Time-Averaged Field Diagnostics #5285
base: development
Are you sure you want to change the base?
Add Time-Averaged Field Diagnostics #5285
Conversation
Thanks for making this PR! One complication is that with #5176, adaptive timestepping will be possible. This means that the timestep length can change, so simply summing the multifabs and dividing by the period won't be enough for a proper time average. I don't think addressing this will be too hard, however. |
Thanks, @archermarx! I wasn't aware of that yet. 🙂 We can do a follow-up and catch if |
Yep, my thought exactly. The adaptive timestepping PR was just merged, too. |
I think #5296 should fix the clang-tidy errors that remain, which don't seem related to this PR. |
- Implement warnings and errors for certain inputs concerning averaging periods
- added first documentation on time averaged diags - put more operations on summation multifabs into if-environments
- added time averaged diags to laser-ion acceleration example - fix first issues that came up when testing this
af628fc
to
822034d
Compare
for more information, see https://pre-commit.ci
This PR adds time-averaged field diagnostics to the WarpX output
Currently, compiling for GPU creates a linking error. We would like to see the CI output to possibly find the issue.
Hence, we do not flag this as WIP right now.
This PR is based on work performed during the 2024 WarpX Refactoring Hackathon and was created together with @RevathiJambunathan. 🙂
Successfully merging this pull request may close #5165.