Fix clang-tidy errors

ECP-WarpX · Sep 20, 2024 · 54bdb71 · 54bdb71
1 parent 98f9670
commit 54bdb71
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/Source/FieldSolver/WarpXPushFieldsEM.cpp b/Source/FieldSolver/WarpXPushFieldsEM.cpp
@@ -112,22 +112,22 @@ void WarpX::PSATDForwardTransformEB ()
     for (int lev = 0; lev <= finest_level; ++lev)
     {
         if (m_fields.has_vector(Efield_fp_string, lev)) {
-            ablastr::fields::VectorField E_fp =  m_fields.get_alldirs(Efield_fp_string, lev);
+            ablastr::fields::VectorField const E_fp =  m_fields.get_alldirs(Efield_fp_string, lev);
             ForwardTransformVect(lev, *spectral_solver_fp[lev], E_fp, Idx.Ex, Idx.Ey, Idx.Ez);
         }
         if (m_fields.has_vector(Bfield_fp_string, lev)) {
-            ablastr::fields::VectorField B_fp =  m_fields.get_alldirs(Bfield_fp_string, lev);
+            ablastr::fields::VectorField const B_fp =  m_fields.get_alldirs(Bfield_fp_string, lev);
             ForwardTransformVect(lev, *spectral_solver_fp[lev], B_fp, Idx.Bx, Idx.By, Idx.Bz);
         }
 
         if (spectral_solver_cp[lev])
         {
             if (m_fields.has_vector(Efield_cp_string, lev)) {
-                ablastr::fields::VectorField E_cp =  m_fields.get_alldirs(Efield_cp_string, lev);
+                ablastr::fields::VectorField const E_cp =  m_fields.get_alldirs(Efield_cp_string, lev);
                 ForwardTransformVect(lev, *spectral_solver_cp[lev], E_cp, Idx.Ex, Idx.Ey, Idx.Ez);
             }
             if (m_fields.has_vector(Bfield_cp_string, lev)) {
-                ablastr::fields::VectorField B_cp =  m_fields.get_alldirs(Bfield_cp_string, lev);
+                ablastr::fields::VectorField const B_cp =  m_fields.get_alldirs(Bfield_cp_string, lev);
                 ForwardTransformVect(lev, *spectral_solver_cp[lev], B_cp, Idx.Bx, Idx.By, Idx.Bz);
             }
         }
@@ -146,25 +146,25 @@ void WarpX::PSATDBackwardTransformEB ()
     for (int lev = 0; lev <= finest_level; ++lev)
     {
         if (m_fields.has_vector(Efield_fp_string, lev)) {
-            ablastr::fields::VectorField E_fp =  m_fields.get_alldirs(Efield_fp_string, lev);
+            ablastr::fields::VectorField const E_fp =  m_fields.get_alldirs(Efield_fp_string, lev);
             BackwardTransformVect(lev, *spectral_solver_fp[lev], E_fp,
                                   Idx.Ex, Idx.Ey, Idx.Ez, m_fill_guards_fields);
         }
         if (m_fields.has_vector(Bfield_fp_string, lev)) {
-            ablastr::fields::VectorField B_fp =  m_fields.get_alldirs(Bfield_fp_string, lev);
+            ablastr::fields::VectorField const B_fp =  m_fields.get_alldirs(Bfield_fp_string, lev);
             BackwardTransformVect(lev, *spectral_solver_fp[lev], B_fp,
                                   Idx.Bx, Idx.By, Idx.Bz, m_fill_guards_fields);
         }
 
         if (spectral_solver_cp[lev])
         {
             if (m_fields.has_vector(Efield_cp_string, lev)) {
-                ablastr::fields::VectorField E_cp =  m_fields.get_alldirs(Efield_cp_string, lev);
+                ablastr::fields::VectorField const E_cp =  m_fields.get_alldirs(Efield_cp_string, lev);
                 BackwardTransformVect(lev, *spectral_solver_cp[lev], E_cp,
                                       Idx.Ex, Idx.Ey, Idx.Ez, m_fill_guards_fields);
             }
             if (m_fields.has_vector(Bfield_cp_string, lev)) {
-                ablastr::fields::VectorField B_cp =  m_fields.get_alldirs(Bfield_cp_string, lev);
+                ablastr::fields::VectorField const B_cp =  m_fields.get_alldirs(Bfield_cp_string, lev);
                 BackwardTransformVect(lev, *spectral_solver_cp[lev], B_cp,
                                       Idx.Bx, Idx.By, Idx.Bz, m_fill_guards_fields);
             }
@@ -175,8 +175,8 @@ void WarpX::PSATDBackwardTransformEB ()
     for (int lev = 0; lev <= finest_level; ++lev)
     {
         if (m_fields.has_vector(Efield_fp_string, lev) && m_fields.has_vector(Bfield_fp_string, lev)) {
-            ablastr::fields::VectorField E_fp =  m_fields.get_alldirs(Efield_fp_string, lev);
-            ablastr::fields::VectorField B_fp =  m_fields.get_alldirs(Bfield_fp_string, lev);
+            ablastr::fields::VectorField const E_fp =  m_fields.get_alldirs(Efield_fp_string, lev);
+            ablastr::fields::VectorField const B_fp =  m_fields.get_alldirs(Bfield_fp_string, lev);
             DampFieldsInGuards(lev, E_fp, B_fp);
         }
     }

diff --git a/Source/ablastr/fields/MultiFabRegister.H b/Source/ablastr/fields/MultiFabRegister.H
@@ -291,7 +291,7 @@ namespace ablastr::fields
          */
         [[nodiscard]] bool
         has_vector (
-            std::string name,
+            std::string const & name,
             int level
         ) const;
 

diff --git a/Source/ablastr/fields/MultiFabRegister.cpp b/Source/ablastr/fields/MultiFabRegister.cpp
@@ -331,15 +331,15 @@ namespace ablastr::fields
 
     bool
     MultiFabRegister::has_vector (
-        std::string name,
+        std::string const & name,
         int level
     ) const
     {
         const std::vector<Direction> all_dirs = {Direction{0}, Direction{1}, Direction{2}};
 
-        int count = 0;
+        unsigned long count = 0;
         for (const Direction& dir : all_dirs) {
-            std::string internal_name = mf_name(name, dir, level);
+            std::string const internal_name = mf_name(name, dir, level);
             count += m_mf_register.count(internal_name);
         }