Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-1700 — fixes to trait mapping pipeline #79

Merged
merged 8 commits into from
Oct 16, 2019

Conversation

tskir
Copy link
Member

@tskir tskir commented Oct 10, 2019

  • Refactor & code cleanup
    • Traits are now processed in parallel, increasing performance (approx. 8× boost, from 0.5 traits/s to 4 traits/s)
    • Simplify retry policy for json_request, remove unnecessary helpers. Now using an external retry library
    • Configure correct handling of different error types; do not ignore any request errors unless directly specified.
  • Fixes for OxO queries
  • Logs cleanup
    • Remove double warning for the same error when OLS didn't return a term label
    • Don't show expected OLS query errors for OMIM and MedGen ontologies (since those two are not present in OLS)
    • Demote "OxO no mappings found" from warning to debug level, because this by itself is not an error — OxO does not guarantee that any cross-refs will be found for any particular input term
    • Default logging level is now DEBUG. This provides the most information, while verbose DEBUG entries can be easily filtered out

@tskir tskir requested review from jmmut and andresfsilva October 10, 2019 13:27
@tskir tskir force-pushed the eva-1700-trait-mapping-fixes branch from 98b5da2 to b26f05c Compare October 10, 2019 13:28
@coveralls
Copy link

coveralls commented Oct 10, 2019

Coverage Status

Coverage increased (+0.1%) to 74.704% when pulling 27e0588 on tskir:eva-1700-trait-mapping-fixes into a5d53ab on EBIvariation:master.

@tskir tskir force-pushed the eva-1700-trait-mapping-fixes branch from b26f05c to 4425501 Compare October 10, 2019 13:48
@tskir tskir force-pushed the eva-1700-trait-mapping-fixes branch 4 times, most recently from 3f1678b to e18593b Compare October 11, 2019 13:05
@tskir tskir force-pushed the eva-1700-trait-mapping-fixes branch from e18593b to 27e0588 Compare October 11, 2019 13:12
@tskir
Copy link
Member Author

tskir commented Oct 16, 2019

Merging after one approval as per discussion with @jmmut

@tskir tskir merged commit a89d4d4 into EBIvariation:master Oct 16, 2019
@tskir tskir deleted the eva-1700-trait-mapping-fixes branch January 14, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants