Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic for correct CURIE format in Linker #722

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Conversation

haideriqbal
Copy link
Collaborator

No description provided.

@henrietteharmse
Copy link
Collaborator

henrietteharmse commented Aug 28, 2024

Implementation seems sound and as a side effect got rid of self references.
All test output looks correct.
Nicely done!

There is no test case for the oio issue currently. To address, please add oio to .json of eg gitIssue502.

Copy link
Collaborator

@henrietteharmse henrietteharmse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@haideriqbal haideriqbal merged commit bead62e into dev Sep 5, 2024
1 check passed
@haideriqbal haideriqbal deleted the fix-curie-issue-oio branch September 5, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants