Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting problems. #2

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix linting problems. #2

merged 1 commit into from
Apr 12, 2024

Conversation

mberacochea
Copy link
Member

Fix the linting issues.

Copy link

github-actions bot commented Apr 12, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 07c210e

+| ✅ 117 tests passed       |+
#| ❔  39 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in ci.yml.bak: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release
  • pipeline_todos - TODO string in WorkflowShallowmapping.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-shallowmapping_logo_light.png
  • files_exist - File is ignored: docs/
  • files_exist - File is ignored: docs/output.md
  • files_exist - File is ignored: docs/README.md
  • files_exist - File is ignored: docs/README.md
  • files_exist - File is ignored: docs/usage.md
  • files_exist - File is ignored: docs/images/nf-core-shallowmapping_logo_dark.png
  • files_exist - File is ignored: docs/images/nf-core-shallowmapping_logo_light.png
  • files_exist - File is ignored: pyproject.toml
  • files_exist - File is ignored: .gitignore
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/*
  • files_exist - File is ignored: .github/CONTRIBUTING.md
  • files_exist - File is ignored: .github/PULL_REQUEST_TEMPLATE.md
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/test.config
  • files_exist - File is ignored: conf/test_full.config
  • files_exist - File is ignored: .github/workflows/ci.yml
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/WorkflowShallowmapping.groovy
  • files_exist - File is ignored: lib/nfcore_external_java_deps.jar
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • nextflow_config - Config variable ignored: process.cpus
  • nextflow_config - Config variable ignored: process.memory
  • nextflow_config - Config variable ignored: process.time
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-shallowmapping_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-shallowmapping_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-shallowmapping_logo_dark.png
  • files_unchanged - File does not exist: docs/README.md
  • actions_ci - '.github/workflows/ci.yml' not found
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/shallowmapping/shallowmapping/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-12 12:28:29

Copy link
Collaborator

@Ales-ibt Ales-ibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I'll revert is data/ in .gitignore file
Thank you so much for this!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove data/ from .gitignore. Otherwise, nf-test fails

@Ales-ibt Ales-ibt merged commit da4dc45 into dev Apr 12, 2024
2 checks passed
@Ales-ibt Ales-ibt deleted the bugfix/fix-linting branch April 12, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants