Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-structure pipeline #134

Merged
merged 12 commits into from
Oct 11, 2024
Merged

Re-structure pipeline #134

merged 12 commits into from
Oct 11, 2024

Conversation

KateSakharova
Copy link

@KateSakharova KateSakharova commented Oct 1, 2024

Restructured pipeline to nf-core view

  • created main.nf main entry
  • added virify.nf to workflows and simplified
  • all subworkflows wrapped into separate files
  • modules moved to local/name/main.nf
  • publishDir moved to modules.config
  • container specified in each module main.nf
  • moved help to separate module
  • moved warning to separate module
  • removed CWL (woohoo)
  • added samplesheet support
  • removed --list option (replaced with samplesheet)
  • replaced name with meta (resolved issues with --list option)
  • added some nf-core tools

Now virify supports samplesheet (fq1 and fq2 are optional)
id,assembly,fq1,fq2

For assembly as input:
If you have assembly as input you can use old argument --fasta - that will run pipieline for 1 assembly.
If you have more than 1 assembly - use samplesheet.

For raw_reads as input:
You need to use ONLY samplesheet (even for 1 run). I replaced --illumina option with --assemble (boolean). User should specify that flag to force assembly process (that flag will help user to understand what he is doing). Hopefully, nobody uses it because it is experimental feature.

Adjustment of the voting scheme and updated viral taxonomy and bugfixes for new release
Merge small set of fixes for new release #123
@KateSakharova KateSakharova changed the base branch from master to dev October 2, 2024 16:03
@KateSakharova KateSakharova marked this pull request as ready for review October 2, 2024 16:03
viphos_annotations = ANNOTATION.out.map { _, __, annotations -> annotations }.collect()
taxonomy_annotations = ASSIGN.out.map { _, __, taxonomy -> taxonomy }.collect()
checkv_results = CHECKV.out.map { _, __, quality_summary, ___ -> quality_summary }.collect()
viphos_annotations = ANNOTATION.out.annotations.groupTuple().map{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this groupTuple required becase ANNOTATION return a list of files? I'm not sure I follow

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is in development stage yet, I'm not sure what it returns either :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect hehe

@mberacochea
Copy link
Member

So far.. it look goods to me :) Thank you @KateSakharova

@KateSakharova KateSakharova requested a review from hoelzer October 7, 2024 13:38
@KateSakharova KateSakharova force-pushed the feature/re-structure-pipeline branch from cd0039a to 74d296b Compare October 7, 2024 14:04
@KateSakharova KateSakharova merged commit 0c20229 into dev Oct 11, 2024
1 check passed
@KateSakharova KateSakharova deleted the feature/re-structure-pipeline branch October 11, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants