Order/Orders: Removes redundant methods

EA31337 · Sep 12, 2021 · d617fa4 · d617fa4
1 parent 7038d6a
commit d617fa4
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 51 deletions.
diff --git a/Order.mqh b/Order.mqh
@@ -287,14 +287,6 @@ class Order : public SymbolInfo {
    */
   bool IsOpen(bool _refresh = false) { return !IsClosed(_refresh); }
 
-  /**
-   * Check whether order is active and open.
-   */
-  bool IsOrderOpen() {
-    Refresh();
-    return OrderOpenTime() > 0 && !(OrderCloseTime() > 0);
-  }
-
   /**
    * Should order be closed.
    *

diff --git a/Orders.mqh b/Orders.mqh
@@ -143,49 +143,6 @@ class Orders {
     return NULL;
   }
 
-  /**
-   * Select the first opened order.
-   */
-  Order *SelectFirstOpen(ENUM_ORDERS_POOL _pool = ORDERS_POOL_TRADES) {
-    // @todo: Implement different pools.
-    for (int _pos = 0; _pos < ArraySize(orders); _pos++) {
-      if (orders[_pos].IsOrderOpen()) {
-        return orders[_pos].TryOrderSelect() ? orders[_pos] : NULL;
-      }
-    }
-    return NULL;
-  }
-
-  /**
-   * Select the most profitable order.
-   */
-  Order *SelectMostProfitable(ENUM_ORDERS_POOL _pool = ORDERS_POOL_TRADES) {
-    // @todo: Implement different pools.
-    Order *_selected = SelectFirstOpen();
-    for (uint _pos = ArraySize(orders); _pos >= 0; _pos--) {
-      if (orders[_pos].IsOrderOpen() &&
-          orders[_pos].Get<float>(ORDER_PROP_PROFIT) > _selected.Get<float>(ORDER_PROP_PROFIT)) {
-        _selected = orders[_pos];
-      }
-    }
-    return _selected.TryOrderSelect() ? _selected : NULL;
-  }
-
-  /**
-   * Select the most unprofitable order.
-   */
-  Order *SelectMostUnprofitable(ENUM_ORDERS_POOL _pool = ORDERS_POOL_TRADES) {
-    // @todo: Implement different pools.
-    Order *_selected = SelectFirstOpen();
-    for (uint _pos = ArraySize(orders); _pos >= 0; _pos--) {
-      if (orders[_pos].IsOrderOpen() &&
-          orders[_pos].Get<float>(ORDER_PROP_PROFIT) < _selected.Get<float>(ORDER_PROP_PROFIT)) {
-        _selected = orders[_pos];
-      }
-    }
-    return _selected.TryOrderSelect() ? _selected : NULL;
-  }
-
   /* Calculation and parsing methods */
 
   /**