Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for p3 tests CMake settings #3114

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fixes for p3 tests CMake settings #3114

merged 2 commits into from
Nov 14, 2024

Conversation

jgfouca
Copy link
Member

@jgfouca jgfouca commented Nov 14, 2024

p3_tests needs to have baseline_gen label. Also, avoid doing thread spreads when generating.

p3_tests needs to have baseline_gen label. Also, avoid doing
thread spreads when generating.
@jgfouca jgfouca requested a review from bartgol November 14, 2024 18:25
@jgfouca jgfouca added CI: Skip weaver CI: skip eamxx-v1 Skip eamxx CIME testing for this PR CI: automerge WARNING: Still in an experimental phase labels Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟠 Enforce checks passing

Waiting checks: gcc-cuda / ${{ matrix.build_type }}, gcc-cuda / dbg, gcc-cuda / opt, gcc-cuda / sp, gcc-openmp / ${{ matrix.build_type }}, gcc-openmp / dbg, gcc-openmp / opt, gcc-openmp / sp.

Make sure that checks are not failing on the PR, and reviewers approved

  • any of:
    • check-skipped={% raw %}gcc-openmp / ${{ matrix.build_type }}{% endraw %}
    • all of:
      • check-success="gcc-openmp / dbg"
      • check-success="gcc-openmp / opt"
      • check-success="gcc-openmp / sp"
      • check-success="gcc-openmp / fpe"
  • any of:
    • check-skipped={% raw %}gcc-cuda / ${{ matrix.build_type }}{% endraw %}
    • all of:
      • check-success="gcc-cuda / dbg"
      • check-success="gcc-cuda / opt"
      • check-success="gcc-cuda / sp"
  • #approved-reviews-by >= 1
  • #changes-requested-reviews-by == 0
  • any of:
    • check-skipped={% raw %}cpu-gcc / ${{ matrix.test.short_name }}{% endraw %}
    • all of:
      • check-success="cpu-gcc / ERS_Ln22.ne4pg2_ne4pg2.F2010-SCREAMv1.scream-small_kernels--scream-output-preset-5"
      • check-success="cpu-gcc / ERS_Ln9.ne4_ne4.F2000-SCREAMv1-AQP1.scream-output-preset-2"
      • check-success="cpu-gcc / ERS_P16_Ln22.ne30pg2_ne30pg2.FIOP-SCREAMv1-DP.scream-dpxx-arm97"
      • check-success="cpu-gcc / SMS_D_Ln5.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.scream-mam4xx-all_mam4xx_procs"
  • any of:
    • check-skipped=cpu-gcc
    • check-success=cpu-gcc

@bartgol
Copy link
Contributor

bartgol commented Nov 14, 2024

@jgfouca feel free to merge and regen baselines (only on gcc-openmp, since gcc-cuda is down anyways).

@jgfouca jgfouca merged commit 90ef094 into master Nov 14, 2024
9 of 16 checks passed
@jgfouca jgfouca deleted the jgfouca/p3_cmake_fixes branch November 14, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: automerge WARNING: Still in an experimental phase CI: skip eamxx-v1 Skip eamxx CIME testing for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants