Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework vertical remapper #3113

Closed
wants to merge 3 commits into from
Closed

Conversation

bartgol
Copy link
Contributor

@bartgol bartgol commented Nov 14, 2024

Compared to previous version:

  • Allow to build the remapper from existing grids (rather than read tgt from file)
  • Handle masked as well as P0 extrapolation
  • Handle top/bot extrapolations separately

This PR is a pre-requisite for the work on unifying our input data interpolation.

* Allow to build from existing grids
* Handle masked as well as P0 extrapolation
* Handle top/bot extrapolations separately
@bartgol bartgol added the BFB Bit for bit label Nov 14, 2024
@bartgol bartgol self-assigned this Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟠 Enforce checks passing

Waiting checks: gcc-cuda / ${{ matrix.build_type }}, gcc-cuda / dbg, gcc-cuda / opt, gcc-cuda / sp.

Make sure that checks are not failing on the PR, and reviewers approved

  • any of:
    • check-skipped={% raw %}gcc-cuda / ${{ matrix.build_type }}{% endraw %}
    • all of:
      • check-success="gcc-cuda / dbg"
      • check-success="gcc-cuda / opt"
      • check-success="gcc-cuda / sp"
  • #approved-reviews-by >= 1
  • #changes-requested-reviews-by == 0
  • any of:
    • all of:
      • check-success="gcc-openmp / dbg"
      • check-success="gcc-openmp / fpe"
      • check-success="gcc-openmp / opt"
      • check-success="gcc-openmp / sp"
    • check-skipped={% raw %}gcc-openmp / ${{ matrix.build_type }}{% endraw %}
  • any of:
    • all of:
      • check-success="cpu-gcc / ERS_Ln22.ne4pg2_ne4pg2.F2010-SCREAMv1.scream-small_kernels--scream-output-preset-5"
      • check-success="cpu-gcc / ERS_Ln9.ne4_ne4.F2000-SCREAMv1-AQP1.scream-output-preset-2"
      • check-success="cpu-gcc / ERS_P16_Ln22.ne30pg2_ne30pg2.FIOP-SCREAMv1-DP.scream-dpxx-arm97"
      • check-success="cpu-gcc / SMS_D_Ln5.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.scream-mam4xx-all_mam4xx_procs"
    • check-skipped={% raw %}cpu-gcc / ${{ matrix.test.short_name }}{% endraw %}
  • any of:
    • check-skipped=cpu-gcc
    • check-success=cpu-gcc

@bartgol bartgol added the CI: automerge WARNING: Still in an experimental phase label Nov 20, 2024
@rljacob
Copy link
Member

rljacob commented Dec 12, 2024

Moved to E3SM-Project/E3SM#6770

@rljacob rljacob closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB Bit for bit CI: automerge WARNING: Still in an experimental phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants