Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-7366] Fix CER crash on ConnectorViewModel #15816

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

reddyashish
Copy link
Contributor

Purpose

https://jira.autodesk.com/browse/DYN-7366

After the fix on 3.3, we had couple of CER reports which are related to the connector redraw().

Added additional null check on ConnectorPinViewCollection as we are checking the count of that collection. Added a try catch around it as well.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

[DYN-7366] Fix CER crash on ConnectorViewModel

Reviewers

@saintentropy

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7366

@QilongTang QilongTang added this to the 3.5 milestone Feb 11, 2025
@reddyashish reddyashish merged commit 171e233 into DynamoDS:master Feb 11, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants