Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeView Icon xaml simplification #15763

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjkkirschner
Copy link
Member

Purpose

extracts some changes from:
#15749 by @dimven

does the following:

  • uses freeze and lower image rendering quality for icons on the node view
  • removes style trigger for dealing with null icon - provides null fallback
  • replaces zoom grid with images / wrap panel

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

@mjkkirschner mjkkirschner changed the title move wpf icon cleanup here NodeView Icon simplification Jan 17, 2025
@mjkkirschner mjkkirschner changed the title NodeView Icon simplification NodeView Icon xaml simplification Jan 17, 2025
Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant