Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing problem with zero term error texts #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cybearinsight
Copy link
Collaborator

I have change the limit on the error text to be limit on the call and actual length on the return. And I have updated the apl function to reflect that

I have left the Topic, Key and payload unchanged since we are using APL both and the producing and consuming end to handle the number of bytes, no matter it is text or binary.

I have change the limit on the error text to be limit on the call and actual length on the return.
And I have updated the apl function to reflect that
@mkromberg
Copy link

Without any technical understanding of this, I still thought I would comment that I do not understand the comment about using APL at both ends. I don't think that will be the typical use case for a Kafka interface.

@cybearinsight
Copy link
Collaborator Author

We are not using zero termination on Topic, Key and Payload, the length is handle on APL with the shape and on the kafka side with a length field. But some of the error codes was handled as zero terminated and the length did not include the zero termination, so now I also return the length on the error messages from the C side to APL.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 8: you may want to add a 4↑ before Produce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants