Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve serverless v3 breaking changes #126

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

DhruvPhumbhra
Copy link
Collaborator

The previous deploy failed because of a serverless issue. Upon further research, I found that serverless v3 has deprecated some features we were using. Namely:

# old syntax
service:
  name: foo-service

# new syntax
service: foo-service

@DhruvPhumbhra
Copy link
Collaborator Author

The previous deploy failed because of a serverless issue. Upon further research, I found that serverless v3 has deprecated some features we were using. Namely:

# old syntax
service:
  name: foo-service

# new syntax
service: foo-service

Note: I'm a little confused about what happens with the config variable that used to be nested under service. The serverless guide for cloudflare workers doesn't seem to have been updated for v3. If this fails, I can force the app to use serverless v2 and try again

@DhruvPhumbhra DhruvPhumbhra merged commit 9940006 into main Oct 6, 2023
8 checks passed
@DhruvPhumbhra DhruvPhumbhra deleted the serverless-v3 branch October 6, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants