Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scalafix rules for 0.4.x -> 0.5.x #233

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

CJSmith-0141
Copy link
Contributor

Take three haha

@CJSmith-0141 CJSmith-0141 requested a review from a team as a code owner January 2, 2024 22:09
@bpholt bpholt self-assigned this Jan 3, 2024
@bpholt
Copy link
Member

bpholt commented Jan 17, 2024

@CJSmith-0141 I'm going to merge this and then follow up with some tweaks to the build definition—it looks like the scalafix artifacts are not being published from CI with the separate build.sbt. I don't think there's a reason that needs to be separate, though, so I'll just combine those pieces into the main build.

Are you working on the additional Scalafix cases? If not, I'll take a look.

@bpholt bpholt merged commit ced20c5 into Dwolla:series/0.5 Jan 17, 2024
13 checks passed
@CJSmith-0141
Copy link
Contributor Author

@CJSmith-0141 I'm going to merge this and then follow up with some tweaks to the build definition—it looks like the scalafix artifacts are not being published from CI with the separate build.sbt. I don't think there's a reason that needs to be separate, though, so I'll just combine those pieces into the main build.

Are you working on the additional Scalafix cases? If not, I'll take a look.

I was giving it a shot but couldn't get the index based calls and the argument named calls to refactor in the same pass correctly. Would be easier to patch the patch but I don't know if that's doable or advisable.

@bpholt bpholt added this to the v0.5 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants