-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support encrypting for multiple recipients (and add Scala 3 support) #211
Conversation
@CJSmith-0141 can you take a look and let me know what you think, or if you have any questions? |
Thank you for taking this up! I'll take a look at in and provide a review / feedback / ask questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much more comprehensive than my attempt, thank you! +1
ed9ba93
to
3d0eaa2
Compare
I was thinking that I should hold off on merging this until the Scalafixes are done, but I just realized we can go ahead and merge—Scala Steward won't suggest updates until this is actually released, and we can hold off on that until the Scalafixes are ready. In the meantime, we can use the snapshot that will be published on the merge. |
@bpholt What are you referring to with Scalafixes? Thank you for cutting a release on the |
e.g. a Scalafix rule to rewrite a method call from Here's the list of rules I came up with:
|
As an FYI @bpholt I cut a release based on this branch on my fork and have been using it in Scala 3 without issue. I couldn't figure out how to keep Scala |
3d0eaa2
to
e828100
Compare
note: this is not binary compatible with previous versions of the library due to the interface changes required to support multiple keys.
…correct key introducing this required LoggerFactory in places where we used to get away with Logger, so it introduces further binary incompatibilities. as such, the remaining compatibility shims have been cleaned up
e828100
to
72d0596
Compare
In order to add support for Scala 3, we need to update to Refined 0.11 and swap out Shapeless tagged types with a Scala-3 compatible library like Monix Newtypes. Since that all requires making changes to the ABI, it's a good opportunity to remove a lot of bincompat cruft that had built up, and also make the core algebras available independently. This omnibus PR does all of that.
I'm working on Scalafixes for the source-breaking changes, so hopefully we can have those ready for Scala Steward to run before this is released as
v0.5.0
.