Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When present, copy http.response.status_code to http.status_code #4

Merged
merged 1 commit into from
Oct 3, 2024
Merged

When present, copy http.response.status_code to http.status_code #4

merged 1 commit into from
Oct 3, 2024

Conversation

bpholt
Copy link
Member

@bpholt bpholt commented Oct 3, 2024

… because the latter is what X-Ray uses, despite it being deprecated.

@bpholt
When present, copy http.response.status_code to http.status_code, bec…
44609a5 
…ause the latter is what X-Ray uses, despite it being deprecated
@bpholt bpholt self-assigned this Oct 3, 2024
@bpholt bpholt requested a review from a team as a code owner October 3, 2024 21:52
dmunney
dmunney approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@dmunney dmunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpholt bpholt merged commit 6b5d2dd into main Oct 3, 2024
5 checks passed
@bpholt bpholt deleted the http.status_code branch October 3, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmunney dmunney dmunney approved these changes

Assignees

@bpholt bpholt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpholt @dmunney