Add SysID Configuration mode #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GBKP
reviewed
Jan 18, 2024
| // autoChooser.addOption( | ||
| // "Flywheel FF Characterization", | ||
| // new FeedForwardCharacterization( | ||
| // flywheel, flywheel::runVolts, flywheel::getCharacterizationDriveVelocity)); |
There was a problem hiding this comment.
Aren't we just going un comment this out when we make autos? If we know we are going to use this at some point I'm not sure about commenting it out.
There was a problem hiding this comment.
yes, but this code will cause build to fail if it's uncommented because of changes that I made for the future. We will use this code, but changes need to be made when changes on another branch are merged
GBKP
approved these changes
Jan 19, 2024
|
go merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sysID configuration mode, this mode automatically collects data for sysID so that characterization is made easier.