Skip to content

Commit

Permalink
feat: Added branchId & directoryId param in list language translations
Browse files Browse the repository at this point in the history
  • Loading branch information
Durdush committed Feb 25, 2024
1 parent 6061f2d commit 913f2db
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ public void removeApproval(Long projectId, Long approvalId) throws HttpException
* @param stringIds filter translations by stringIds
* @param labelIds filter translations by labelIds
* @param fileId filter translations by file identifier
* @param branchId filter translations by branchId
* @param directoryId filter translations by directoryId
* @param croql filter translations by croql
* @param denormalizePlaceholders enable denormalize placeholders
* @param limit maximum number of items to retrieve (default 25)
Expand All @@ -119,12 +121,14 @@ public void removeApproval(Long projectId, Long approvalId) throws HttpException
* <li><a href="https://developer.crowdin.com/enterprise/api/v2/#operation/api.projects.languages.translations.getMany" target="_blank"><b>Enterprise API Documentation</b></a></li>
* </ul>
*/
public ResponseList<LanguageTranslations> listLanguageTranslations(Long projectId, String languageId, String stringIds, String labelIds, Long fileId, String croql, Integer denormalizePlaceholders, Integer limit, Integer offset) throws HttpException, HttpBadRequestException {
public ResponseList<LanguageTranslations> listLanguageTranslations(Long projectId, String languageId, String stringIds, String labelIds, Long fileId, Long branchId, Long directoryId, String croql, Integer denormalizePlaceholders, Integer limit, Integer offset) throws HttpException, HttpBadRequestException {
String builtUrl = String.format("%s/projects/%d/languages/%s/translations", this.url, projectId, languageId);
Map<String, Optional<Object>> queryParams = HttpRequestConfig.buildUrlParams(
"stringIds", Optional.ofNullable(stringIds),
"labelIds", Optional.ofNullable(labelIds),
"fileId", Optional.ofNullable(fileId),
"branchId", Optional.ofNullable(branchId),
"directoryId", Optional.ofNullable(directoryId),
"croql", Optional.ofNullable(croql),
"denormalizePlaceholders", Optional.ofNullable(denormalizePlaceholders),
"limit", Optional.ofNullable(limit),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,23 +93,23 @@ public void removeApprovalTest() {

@Test
public void listLanguageTranslationsPlainTest() {
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(projectId, language, null, null, null, null, null, null, null);
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(projectId, language, null, null, null,null,null, null, null, null, null);
assertEquals(1, languageTranslationsList.getData().size());
assertTrue(languageTranslationsList.getData().get(0).getData() instanceof PlainLanguageTranslations, "Wrong return type, must be PlainLanguageTranslations");
assertEquals(stringId, ((PlainLanguageTranslations) languageTranslationsList.getData().get(0).getData()).getStringId());
}

@Test
public void listLanguageTranslationsPluralTest() {
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(secondProjectId, language, null, null, null, null, null, null, null);
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(secondProjectId, language, null, null, null, null,null,null, null, null, null);
assertEquals(1, languageTranslationsList.getData().size());
assertTrue(languageTranslationsList.getData().get(0).getData() instanceof PluralLanguageTranslations, "Wrong return type, must be PluralLanguageTranslations");
assertEquals(stringId, ((PluralLanguageTranslations) languageTranslationsList.getData().get(0).getData()).getStringId());
}

@Test
public void listLanguageTranslationsICUTest() {
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(thirdProjectId, language, null, null, null, null, null, null, null);
ResponseList<LanguageTranslations> languageTranslationsList = this.getStringTranslationsApi().listLanguageTranslations(thirdProjectId, language, null, null, null, null, null, null, null, null, null);
assertEquals(1, languageTranslationsList.getData().size());
assertTrue(languageTranslationsList.getData().get(0).getData() instanceof ICULanguageTranslations, "Wrong return type, must be ICULanguageTranslations");
assertEquals(stringId, ((ICULanguageTranslations) languageTranslationsList.getData().get(0).getData()).getStringId());
Expand Down

0 comments on commit 913f2db

Please sign in to comment.