Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTT improvements and fixes #923

Merged
merged 18 commits into from
Oct 27, 2023
Merged

MQTT improvements and fixes #923

merged 18 commits into from
Oct 27, 2023

Conversation

rechrtb
Copy link
Contributor

@rechrtb rechrtb commented Oct 25, 2023 •
edited
Loading

Follow up to #589.

  • Change subscription max QOS parameter from Q to O in M586.4
  • Removed single default topic configuration in M586.4.
  • Topic to publish to must be specified in M118 via parameter T . QOS, retain and duplicate flags can be optionally specified via Q, R and D in M118
  • Support LWT (last will and testament) QOS and retain flag via parameter Q and R in M586.4.
  • MQTT demonstration script and documentation moved to Duet3D/MQTT-WPA2-Enterprise-Demo.

Closes #880.

rechrtb added 17 commits October 19, 2023 13:36
@rechrtb
Support specifying will qos and retain
40f852c
@rechrtb
Use unique arg for subscribe max qos
ac9603b
@rechrtb
Implement setting topic, qos, retain and dup on M118 MQTT publish
477d4da
@rechrtb
Remove unneeded variable
4fddce7
@rechrtb
Remove need for intermediate output buffer when publishing
f3e47bf
@rechrtb
Some cleanups
fa631c7
@rechrtb
Make publish topic mandatory
a88a03b
@rechrtb
Fix freeze when disabling MQTT
d362d0a
@rechrtb
Create only one mqtt client instance for now
49ff4a4
@rechrtb
Set interface null properly
2a502ec
@rechrtb
Check if client can be enabled on multiple interfaces
c1c79d3
@rechrtb
Remove mqtt demo files
83a005b 
This is moved to another repo
@rechrtb
Fixes for MQTT client
a46d232 
- Fix setting connect flags related to LWT
- Display debug message when changing subscription QOS
- Replace max QOS argument
@rechrtb
Use GetLimitedUIValue for getting qos, retain and dup values
8db6b66
@rechrtb
Use same names for mqtt client mutex
85365aa
@rechrtb
Remove unecessary code for multiple mqtt clients
cddb535 
Since MQTT client is implemented as a singleton for now, remove code
related to partially handling multiple instances.
@rechrtb
Clear send buffer error manually
2eedbfe
@rechrtb rechrtb mentioned this pull request Oct 25, 2023
Closed
@dc42 dc42 merged commit e0dfb25 into Duet3D:3.5-dev Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rechrtb @dc42