Master mollie #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pga-odoo
pushed a commit
that referenced
this pull request
Feb 13, 2023
Issue #1: reading textContent When reading the textContent property of an element, its does not take into account line breaks introduced by <br> and block elements, whilst innerHtml does. This commit solves the issue of updating a link's href to a non-sense url upon label change. Before this commit, "www.abc.com <br> www.xyz.com" was being incorrectely parsed as "www.abc.comwww.xyz.com". Issue #2: setting textContent When setting the textContent property of an element, all of its child nodes are removed and replaced by a single text node. While this is fine when the element contains a single text node, it might not be the desired result when the element contains other children. This commit solves the issue obtained when pasting html such as "link.com<br>link.be" inside an empty inline element such as STRONG or A, in which cleanForSave was changing its content (removing the line-break) due to misuse of textContent, when the intended effected was simply removing ZeroWidthSpace characters. A safer alternative for removing ZeroWidthSpace is thus provided. task-3081254 closes odoo#108521 Signed-off-by: David Monjoie (dmo) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr