Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed gameDir to SDL_GetPrefPath #662

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ty802
Copy link

@ty802 ty802 commented Feb 12, 2024

Changed gameDir to SDL_GetPrefPath to allow use on platforms that require the executable to be in an imutable folder (e.g. MacOS app file)

Note. This also moves game data to appdata on windows and should also respect XDG_DATA_HOME on linux.

@Drewol
Copy link
Owner

Drewol commented Feb 12, 2024

Sounds good. Might need to check how this interacts with #661?

Main/src/GameConfig.cpp Outdated Show resolved Hide resolved
Changed gameDir to SDL_GetPrefPath to allow use on platforms that require the executable to be in an imutable folder (e.g. MacOS app file)

Note. This also moves game data to appdata on windows and should also respect XDG_DATA_HOME
@ty802 ty802 force-pushed the mergebranch-fixpath-02-12-2-50-24 branch from 273461d to bc6cbdc Compare February 12, 2024 22:56
@Drewol Drewol self-requested a review February 12, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants