Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db] Support duplicate charts in song database #463

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

itszn
Copy link
Collaborator

@itszn itszn commented Apr 29, 2021

This change fixes issues that happen when you have multiple charts with the same hash in the database. To do this we now keep a list of duplicates (if there are any) for a given hash. Then when we add scores, we can add them to all duplicates rather than just the one found in chartsByHash.

We also need to pass an initialized map database into ScoreScreen so we can update duplicates as well.

Since this is refactoring some score saving code, wanted to sanity check it

@itszn itszn added the Feature label Apr 29, 2021
@itszn itszn requested a review from Drewol April 29, 2021 18:26
@itszn itszn marked this pull request as draft June 10, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant