Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor starter kit (part 1) #13

Open
wants to merge 48 commits into
base: dev
Choose a base branch
from
Open

Refactor starter kit (part 1) #13

wants to merge 48 commits into from

Conversation

Yehonal
Copy link
Member

@Yehonal Yehonal commented Mar 25, 2023

Changes

  • User app: Handles user registration, authentication, profile management, etc.
  • Post app: Manages all operations related to posts and comments. This includes creating, editing, deleting posts/comments, and managing post/comment visibility and reporting.
  • Cron app: This app could regularly check the database for users whose suspensions are set to expire and reactivate their accounts. It can also perform other routine maintenance tasks like - Cleaning up old, inactive user accounts, Archiving or deleting posts that are too old or violate platform rules.

Direct call scenario:

  • Post app gets the user post information by using the http-strategy

Event-based scenario

  • User app send an event to the Post app when an user is deleted to delete the posts as well if the option is selected. The post app send back an event to the user app

Todo

  • Implement feature tests
  • Implement integration tests
  • Integrate tests into the pipeline
  • Merge and open a second PR for the remaining parts

Out of scope

  • Repository with an app template with the less code possible and based on the starter kit

scripts/src/npm_scripts_lib.js Fixed Show fixed Hide fixed
platform-kit/webpack.config.cjs Fixed Show fixed Hide fixed
@Yehonal Yehonal changed the title Refactor starter kit Refactor starter kit (part 1) Jun 4, 2024

// rimraf dist folder, clean: true is not always working
console.log(`Cleaning ${config.output.path} folder`);
if (cleanFolder) execSync(`npx -y rimraf ${config.output.path}`);

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
.
) =>
commands.forEach((command) => {
try {
execSync(command, {

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
file name
.
This shell command depends on an uncontrolled
absolute path
.
This shell command depends on an uncontrolled
absolute path
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant