Add explicit UTF8 TextEncoding to Streams to fix filters with special characters #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR! I will test and will merge if everything is ok. About UTF-16, I think it's not the right encoding. Since I'm not sure about backward compatibility with ASCII. (utf-16 is 2 bytes per character) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue yesterday where filters with a special character (
Üin a Code field in a German SaaS Environment to be specific) would cause the data editor to not find any records. Substituting the umlaut character with a*got the expected result.Adding explicit UTF8 TextEncoding to CreateInstream and CreateOutstream fixes this issue on my sandbox system.
I don't think this change has any unwanted sideeffects. UTF16 might be better for some asian languages but UTF8 should still work for them.