Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rspack plugin no effect on win32 platform #2517

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

DaiQiangReal
Copy link
Collaborator

Fix: rspack plugin no effect on win32 platform, since win32 use \ as system default sep.

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 修复 Rspack plugin 在 win32 平台不生效的问题

🇺🇸 English

  • Fix: Fixed the issue that Rspack plugin does not work on win32 platform

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@DaiQiangReal DaiQiangReal force-pushed the Fix-rspack-plugin-no-effect-on-win32-platform branch from ea9c045 to ef7499d Compare October 5, 2024 20:12
@DaiQiangReal DaiQiangReal force-pushed the Fix-rspack-plugin-no-effect-on-win32-platform branch from ef7499d to e86adc1 Compare October 5, 2024 20:14
Copy link

codesandbox-ci bot commented Oct 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e86adc1:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Oct 5, 2024

semi-design    Run #2853

Run Properties:  status check passed Passed #2853  •  git commit 8b837d4ce6 ℹ️: Merge e86adc19a9b5cf09bbce30362debdef2feabe0fc into e3d492cb6bf73316034b31c10565...
Project semi-design
Branch Review Fix-rspack-plugin-no-effect-on-win32-platform
Run status status check passed Passed #2853
Run duration 07m 52s
Commit git commit 8b837d4ce6 ℹ️: Merge e86adc19a9b5cf09bbce30362debdef2feabe0fc into e3d492cb6bf73316034b31c10565...
Committer 代强
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 264
View all changes introduced in this branch ↗︎

@pointhalo pointhalo merged commit 99e4871 into main Oct 8, 2024
9 checks passed
@pointhalo pointhalo deleted the Fix-rspack-plugin-no-effect-on-win32-platform branch October 8, 2024 03:12
Copy link

cypress bot commented Oct 8, 2024

semi-design    Run #2854

Run Properties:  status check passed Passed #2854  •  git commit 99e4871731: fix: fix rspack plugin can on win32 platform (#2517)
Project semi-design
Run status status check passed Passed #2854
Run duration 07m 52s
Commit git commit 99e4871731: fix: fix rspack plugin can on win32 platform (#2517)
Committer 代强
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 264
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants