Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update global learners to work with scikit-learn 1.6.0 #291

Open
wants to merge 67 commits into
base: main
Choose a base branch
from
Open

Update global learners to work with scikit-learn 1.6.0 #291

wants to merge 67 commits into from

Conversation

SvenKlaassen
Copy link
Member

@SvenKlaassen SvenKlaassen commented Jan 20, 2025 •
edited
Loading

PR Checklist

Please fill out this PR checklist (see our contributing guidelines for details).

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

@SvenKlaassen
change np.in1d to np.isin
60c34cc
@SvenKlaassen
nonlinear mixin change value of coef to scalar
3918bed
@SvenKlaassen
fix irm tests
ce8c254 
update coefs and ses to scalars
@SvenKlaassen
fix plm tests
1a17056 
update coef and ses to scalars
@SvenKlaassen
Merge branch 'main' into s-maintenance
3da2a42
@SvenKlaassen
ignore not relevant did test warnings
a745a65
@SvenKlaassen
ignore not relevant warnings in plm tests
81b4d57
@SvenKlaassen
update irm test warnings
b98647f
@SvenKlaassen
Update pytest.ini
630c7a2
@SvenKlaassen
Update pytest.ini
cb88bdd
@SvenKlaassen
update irm tests
3803d9f
@SvenKlaassen
Update test_iivm_tune.py
ca2a60a
@SvenKlaassen
filter warnings for rdd
2aaf28b
@SvenKlaassen
add black formatter configuration
2caeabc
@SvenKlaassen
add ruff configuration
cebd465
@SvenKlaassen
update ruff configuration
f369cb2
@SvenKlaassen
run ruff for did
5751524
@SvenKlaassen
reformat did dir
030eeae
@SvenKlaassen
run ruff for irm
f06879d
@SvenKlaassen
reformat irm dir
0251a6f
@SvenKlaassen
run ruff on plm
36ae8b2
@SvenKlaassen
reformat plm
1c31e8b
@SvenKlaassen
run ruff on rdd
28c64e1
@SvenKlaassen
format rdd
11664a2
@SvenKlaassen
run ruff on tests
b55a04f
@SvenKlaassen
format tests
74b6b3f
@SvenKlaassen
run ruff on utils
fd13e1d
@SvenKlaassen
format utils
b49a526
@SvenKlaassen
ruff doubleml
f984773
@SvenKlaassen
format doubleml
68683ac
SvenKlaassen and others added 23 commits January 13, 2025 13:51
@SvenKlaassen
run end-of-file-fixer
ccced2f
@SvenKlaassen
add pre-commit hooks to contributing
72c32d5
@SvenKlaassen
Merge pull request #289 from DoubleML/s-add-black-and-ruff-configs
5962ec1 
Add black and ruff configurations
@SvenKlaassen
update did dataset
d0e3254
@SvenKlaassen
Update test_datasets.py
30b8ace
@SvenKlaassen
Update _utils_irm_manual.py
d1a4915
@SvenKlaassen
Update test_dml_data.py
5bd1d3f
@SvenKlaassen
Update test_dml_data.py
d6ca656
@SvenKlaassen
Refactor test_dml_data.py for improved readability and maintainability
6b18c3f
@SvenKlaassen
update test
065c357
@SvenKlaassen
remove unnecessary variable
661d483
@SvenKlaassen
Update test_pq_tune.py
3b8b257
@SvenKlaassen
Update test_dml_data.py
ba41724
@SvenKlaassen
Update test_sensitivity.py
45b1327
@SvenKlaassen
update PLR examples with clearer learners
55bde25
@SvenKlaassen
Delete .coverage
f3fa0b7
@SvenKlaassen
update global learner docstrings
216295b
@SvenKlaassen
fix sensitivity_benchmark docstring
31a0272
@SvenKlaassen
update sklearn dependency range
97f96f8
@SvenKlaassen
add stacking test
be3aa7f
@SvenKlaassen
add sklearn estimator checks
5c83079
@SvenKlaassen
formatting
9246998
@SvenKlaassen
optional check for global learners if sklearn pre 1.6
9de7fc1
@SvenKlaassen SvenKlaassen linked an issue Jan 20, 2025 that may be closed by this pull request
Sklearn 1.6.0 compatibility #290
Open
@SvenKlaassen SvenKlaassen mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sklearn 1.6.0 compatibility
1 participant
@SvenKlaassen