Skip to content

Commit

Permalink
update test
Browse files Browse the repository at this point in the history
  • Loading branch information
SvenKlaassen committed Jan 13, 2025
1 parent 6b18c3f commit 065c357
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions doubleml/tests/test_dml_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,8 @@ def test_add_vars_in_df():
# additional variables in the df shouldn't affect results
np.random.seed(3141)
df = make_plr_CCDDHNR2018(n_obs=100, return_type="DataFrame")
dml_data_full_df = DoubleMLData(df, "y", "d", ["X1", "X11", "X13"])
df_subset = df[["X1", "X11", "X13", "y", "d"]].copy()
dml_data_subset = DoubleMLData(df_subset, "y", "d", ["X1", "X11", "X13"])
dml_data_full_df = DoubleMLData(df, "y", "d", ["X1", "X2", "X3"])
dml_data_subset = DoubleMLData(df[["X1", "X2", "X3", "y", "d"]], "y", "d", ["X1", "X2", "X3"])

Check failure

Code scanning / CodeQL

Unhashable object hashed Error test

This
instance
of
list
is unhashable.
dml_plr_full_df = DoubleMLPLR(dml_data_full_df, Lasso(), Lasso())
dml_plr_subset = DoubleMLPLR(dml_data_subset, Lasso(), Lasso(), draw_sample_splitting=False)
dml_plr_subset.set_sample_splitting(dml_plr_full_df.smpls)
Expand Down

0 comments on commit 065c357

Please sign in to comment.