Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/65 User Activity not getting captured for false activity started status #66

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

Sachinbisht27
Copy link
Member

#65

Please complete the following steps and check these boxes before filing your PR:

Types of changes

  • Bug fix (a change which fixes an issue)
  • New feature (a change which adds functionality)

Short description of what this resolves:

User Flow Logs Handling: Implemented logic to create a new user flow log if the flow status is marked as 'completed' but no corresponding latest user flow log is found in the database.

Activity Log Processing: Removed the conditional check that processed activity logs only if the 'flow_started' argument was 'yes'. Now, the logic handles both 'yes' and 'no' values for 'flow_started', ensuring comprehensive activity logging.

Checklist:

  • I have performed a self-review of my own code.
  • The code follows the style guidelines of this project.
  • The code changes are passing the CI checks
  • I have documented my code wherever required.
  • The changes requires a change to the documentation.
  • I have updated the documentation based on the my changes.
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Copy link

@thebelrobot thebelrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 review comment

@Sachinbisht27
Copy link
Member Author

Updated the suggested name for the function. @thebelrobot Please have a look again.

Copy link

@thebelrobot thebelrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sachinbisht27 Sachinbisht27 merged commit 30b0468 into develop Jul 17, 2024
1 check passed
@Sachinbisht27 Sachinbisht27 deleted the fix/65-user-activity-not-getting-captured branch July 17, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants