Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/18 user attribute service #48

Merged
merged 2 commits into from
May 23, 2024

Conversation

Sachinbisht27
Copy link
Member

#18

Please complete the following steps and check these boxes before filing your PR:

Types of changes

  • Bug fix (a change which fixes an issue)
  • New feature (a change which adds functionality)

Short description of what this resolves:

  • Handling all custom field data from the Glific webhook.
  • Creating a new entry for every new custom field.
  • Added the logic to update the same entry again once the user changes or updates the details.
  • Added the check not to create multiple entries for the same contact field for a user.

Checklist:

  • I have performed a self-review of my own code.
  • The code follows the style guidelines of this project.
  • The code changes are passing the CI checks
  • I have documented my code wherever required.
  • The changes requires a change to the documentation.
  • I have updated the documentation based on the my changes.
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@Sachinbisht27 Sachinbisht27 requested a review from Satendra-SR May 23, 2024 11:01
@Sachinbisht27 Sachinbisht27 self-assigned this May 23, 2024
@Sachinbisht27 Sachinbisht27 merged commit 131c611 into develop May 23, 2024
1 check passed
@Sachinbisht27 Sachinbisht27 deleted the feature/18-user-attribute-service branch May 23, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants