-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/15 create flow run log service #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes, else looks good
UserFlows.flow_uuid == flow_uuid, | ||
UserFlows.user_phone == user_phone, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gonna take more resources as the table grows. Can we find possibilities to configure index for these two columns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can take it seperately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added indexing in the flow uuid column as well.
api/services/flow_run_log_service.py
Outdated
if not today_flow_log: | ||
user_flow_log = self.create_log(flow_uuid, flow_name, flow_type) | ||
elif today_flow_log and flow_completed: | ||
user_flow_log = self.update_log(today_flow_log) | ||
else: | ||
user_flow_log = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not today_flow_log: | |
user_flow_log = self.create_log(flow_uuid, flow_name, flow_type) | |
elif today_flow_log and flow_completed: | |
user_flow_log = self.update_log(today_flow_log) | |
else: | |
user_flow_log = None | |
user_flow_log = None | |
if not today_flow_log: | |
user_flow_log = self.create_log(flow_uuid, flow_name, flow_type) | |
elif today_flow_log and flow_completed: | |
user_flow_log = self.update_log(today_flow_log) |
#15
Please complete the following steps and check these boxes before filing your PR:
Types of changes
Short description of what this resolves:
Changes contain:
Checklist: