Functionality to capture user activities #23
Conversation
…ebhook-analytics into feature/17-create-user-activities-service
…ebhook-analytics into feature/17-create-user-activities-service
api/models/user_activities.py
Outdated
| .first() | ||
| ) | ||
|
|
||
| def get_succeeded_activity_for_user(self, user_id, user_phone): |
api/services/flow_run_log_service.py
Outdated
| if not today_flow_log: | ||
| if flow_status == self.class_model.FlowRunStatus.COMPLETED: | ||
| user_flow_log = self.update_log(latest_flow_log) | ||
| else: | ||
| user_flow_log = self.create_log(flow_uuid, flow_name, flow_type) |
There was a problem hiding this comment.
We should create a new log only if the start node is available - ie flow_status == "Started", thoughts?
There was a problem hiding this comment.
Yes, thanks for the suggestion. Let me update that.
There was a problem hiding this comment.
@Sachinbisht27 a few comments before we merge the changes. Have a look
.pre-commit-config.yaml
Outdated
| rev: v1.10.0 | ||
| hooks: | ||
| - id: python-use-type-annotations | ||
| - repo: https://github.com/sondrelg/pep585-upgrade |
There was a problem hiding this comment.
Why do we need this?
The GitHub repo is archived now, if this is helpful , we may need to find an alternative - https://github.com/sondrelg/pep585-upgrade
There was a problem hiding this comment.
I was exploring some pre-commit hooks so, we can maintain the TypeHinting in the codebase. I found 2 hooks related to it so added them here. I can explore more if this one is archived now.
#17
Please complete the following steps and check these boxes before filing your PR:
Types of changes
Short description of what this resolves:
Changes contain:
Testing payloads:
{ "contact": { "id": 15356, "name": "User Name", "fields": { "dost_content_completed": { "inserted_at": "2024-04-19T11:44:41.961644Z", "label": "dost_content_completed", "type": "string", "value": "activity_1_sent" }, "flow_execution_date": { "inserted_at": "2023-03-22T07:52:03.097151Z", "label": "flow_execution_date", "type": "string", "value": "Invalid Code" }, "activity_1_started": { "label": "activity_1_started", "type": "string", "value": "true", "inserted_at": "2024-04-29T04:32:45.688102Z" }, "last_flow": { "inserted_at": "2023-03-22T07:40:27.888117Z", "label": "last_flow", "type": "string", "value": "AWS_1" } }, "phone": "+911234567890" }, "current_time": "@calendar", "custom_key": "custom_value", "flow_status": "started", "flow_id": "14194", "flow_name": "Glific_Integration_Test_Flow", "flow_type": "activity", "flow_uuid": "3dddce1e-b76d-42d8-834b-964d70e3a0f9", "organization_id": 11, "activity_1_started": "yes", "results": { "flow_keyword": { "category": "draft:whatsappinit", "input": "draftwhatsappinit", "inserted_at": "2024-04-29T04:32:45.610016Z" } } }{ "contact": { "id": 15356, "name": "User Name", "fields": { "dost_content_completed": { "inserted_at": "2024-04-19T11:44:41.961644Z", "label": "dost_content_completed", "type": "string", "value": "activity_1_sent" }, "flow_execution_date": { "inserted_at": "2023-03-22T07:52:03.097151Z", "label": "flow_execution_date", "type": "string", "value": "Invalid Code" }, "activity_1_success": { "label": "activity_1_success", "type": "string", "value": "true", "inserted_at": "2024-04-29T04:32:45.688102Z" }, "last_flow": { "inserted_at": "2023-03-22T07:40:27.888117Z", "label": "last_flow", "type": "string", "value": "AWS_1" } }, "phone": "+911234567890" }, "current_time": "@calendar", "custom_key": "custom_value", "flow_status": "started", "flow_id": "14194", "flow_name": "Glific_Integration_Test_Flow", "flow_type": "activity", "flow_uuid": "3dddce1e-b76d-42d8-834b-964d70e3a0f9", "organization_id": 11, "activity_1_success": "yes", "results": { "flow_keyword": { "category": "draft:whatsappinit", "input": "draftwhatsappinit", "inserted_at": "2024-04-29T04:32:45.610016Z" } } }{ "contact": { "id": 15356, "name": "User Name", "fields": { "dost_content_completed": { "inserted_at": "2024-04-19T11:44:41.961644Z", "label": "dost_content_completed", "type": "string", "value": "activity_1_sent" }, "flow_execution_date": { "inserted_at": "2023-03-22T07:52:03.097151Z", "label": "flow_execution_date", "type": "string", "value": "Invalid Code" }, "activity_1_completed": { "label": "activity_1_completed", "type": "string", "value": "true", "inserted_at": "2024-04-29T04:32:45.688102Z" }, "last_flow": { "inserted_at": "2023-03-22T07:40:27.888117Z", "label": "last_flow", "type": "string", "value": "AWS_1" } }, "phone": "+911234567890" }, "current_time": "@calendar", "custom_key": "custom_value", "flow_id": "14194", "flow_name": "Glific_Integration_Test_Flow", "flow_type": "activity", "flow_status": "completed", "flow_uuid": "3dddce1e-b76d-42d8-834b-964d70e3a0f9", "organization_id": 11, "activity_1_completed": "yes", "results": { "flow_keyword": { "category": "draft:whatsappinit", "input": "draftwhatsappinit", "inserted_at": "2024-04-29T04:32:45.610016Z" } } }Checklist: