-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resources for managing users in groups #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, @rgharris!
I did some testing locally and I've got a few recommendations. While I was prodding around, I made a few of the changes myself but didn't test them intensively: master...rgharris/group-members+nic
Two commits can be pulled directly in, one fixes an existing docs problem and the other updates our README with more info on docs. The last commit is a fixup for your changes with the following recommendations:
- Change
group_member
resource to reference users and groups with "slug" to match the style of other resources - Add support for importing
group_member
resource which just required adding theResourceImporter
, removing the unnecessary slug check during read, and adding the resource ID section to the docs- This can be tested with
terraform import doppler_group_member.engineering <group_slug>.workplace_user.<user_slug>
- This can be tested with
- Updated docs files and ran
make tfdocs
0a9b53d
to
ece826e
Compare
ece826e
to
5b2c682
Compare
Force push pulls in @nmanoogian's work plus makes a small tweak to handle a change to the API spec and handle a previously unhandled error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [doppler](https://registry.terraform.io/providers/dopplerhq/doppler) ([source](https://togithub.com/DopplerHQ/terraform-provider-doppler)) | required_provider | minor | `~> 1.3.0` -> `~> 1.9.0` | --- ### Release Notes <details> <summary>DopplerHQ/terraform-provider-doppler (doppler)</summary> ### [`v1.9.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.9.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.8.0...v1.9.0) #### What's Changed - Add Fly.io integration + sync and delete_behavior field by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/93](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/93) - Update Go version to v1.22 by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/89](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/89) - Add personal_configs field to environment resource by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/92](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/92) - Add support for kms_key_id in AWS Secrets Manager and Parameter Store syncs by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/94](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/94) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.8.0...v1.9.0 ### [`v1.8.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.8.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.7.1...v1.8.0) #### What's Changed - Add service_account_token resource by [@​srevinsaju](https://togithub.com/srevinsaju) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/86](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/86) - Add doppler_project_role resource by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/88](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/88) - Add webhook resource by [@​kyle-mcguire](https://togithub.com/kyle-mcguire) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/87](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/87) #### New Contributors - 🎉 [@​srevinsaju](https://togithub.com/srevinsaju) made their first contribution in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/86](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/86) - 🎉 [@​kyle-mcguire](https://togithub.com/kyle-mcguire) made their first contribution in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/87](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/87) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.7.1...v1.8.0 ### [`v1.7.1`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.7.1) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.7.0...v1.7.1) - Update dependency versions and add import examples by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/83](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/83) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.7.0...v1.7.1 ### [`v1.7.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.7.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.6.2...v1.7.0) - Add `doppler_secrets_sync_github_actions` resource by [@​watsonian](https://togithub.com/watsonian) in [#​81](https://togithub.com/DopplerHQ/terraform-provider-doppler/issues/81) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.6.2...v1.7.0 ### [`v1.6.2`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.6.2) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.6.1...v1.6.2) - Set ForceNew for `doppler_secret` project and config by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/78](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/78) - Ignore order of project_member environments by [@​rgharris](https://togithub.com/rgharris) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/79](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/79) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.6.1...v1.6.2 ### [`v1.6.1`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.6.1) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.6.0...v1.6.1) - Fix typo in User data source docs by [@​rgharris](https://togithub.com/rgharris) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/76](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/76) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.6.0...v1.6.1 ### [`v1.6.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.6.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.5.0...v1.6.0) - Add resources for managing users in groups by [@​rgharris](https://togithub.com/rgharris) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/72](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/72) - chore: Workflows update by [@​ViacheslavKudinov](https://togithub.com/ViacheslavKudinov) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/75](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/75) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.5.0...v1.6.0 ### [`v1.5.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.5.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.4.0...v1.5.0) - Added resources for Terraform Cloud sync integrations (thanks to [@​sbrudz](https://togithub.com/sbrudz)!) - Updated auth documentation to include environment variable support (thanks to [@​kaldorn](https://togithub.com/kaldorn)!) ### [`v1.4.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.4.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.3.0...v1.4.0) - Updated from Go 1.19 to 1.21 along with some dependency version bumps - Added support for specifying tags to `doppler_secrets_sync_aws_secrets_manager` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/dotkom/monoweb). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR adds resources for managing users in groups. Users are data sources and must be created in Doppler before being managed via Terraform. Note: this depends on unreleased API changes and thus does not work against the production API at the moment.
Closes #66
Closes ENG-7342