-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] - Add export buttons to lists #193
base: master
Are you sure you want to change the base?
Conversation
93141de
to
6a18a87
Compare
Re-done my commits to include the correct author name and email. |
1a57d65
to
f8f7053
Compare
Example spools CSV exported from my instance
|
This is really nice, something I've been thinking of doing myself. I noticed a few minor issues regarding missing columns:
|
@Donkie After some investigation I found the issue regarding the missing columns. The CSV export is outdated (uses a version from 5 years ago), it has a bug where the headers for the data come from the keys of the first object in the data array Source code of export-to-csv I can't specify the headers manually currently, the API will not return non-set fields (it will return an empty string if you set and unset it). Currently I have few options
I will go with option 2 for now, I will try to see how seamless it can be (without affecting the DB). |
@Donkie I saw that Is there a reason why |
Looks like option 1 is on its way, so I think we can merge this and then update when its available. Regarding your question, that was just a design choice I made, to discard nullable fields entirely if they are not set. |
Empty cell is more preferable imo |
@vikavorkin are you waiting for me to do something here to continue? |
The refine fix is scheduled for January, not sure how Spoolman will handle the update, I guess it would be ok. For now I can bring the CSV generation to Spoolman for now just to avoid the issues described, dropping it once refine's fix is released. What you the think? |
I think it would be cool if you can get the CSV generation into Spoolman, then we're less dependent on refine |
Hi @Donkie, sorry for the delay, didn't have much time for contribution. |
No worries, take your time :) |
@vikavorkin any update on this? Would be nice if manufacturers of filament can share a whole database of filaments :-) best |
@vikavorkin or @Donkie what is missing for merge? |
Hi @P-C-R From what I saw, refine released my fix to the export in https://github.com/refinedev/refine/releases/tag/%40refinedev/core%404.47.0 Regarding the sharing of spool data by manufacturers, this is out of scope for this PR. |
6dd5b6c
to
babb95d
Compare
…refinedev Signed-off-by: Vika <[email protected]>
8302f84
to
ad8f914
Compare
@vikavorkin @P-C-R work has started on a unified filament database here: https://github.com/Donkie/SpoolmanDB |
Hi,
The default print QC codes dialog wasn't enough for me, trying to print labels using my brother label forces me to use their software.
The simplest thing was to export the data to a CSV and go from there.
Using the default export functionality of
refinedev
simply dumps the raw table data to a CSV file, this can be customized but it was enough for me.The only issue I'm seeing is the QR code generation for those who may try to use the CSV, the code generates it as
web+spoolman:s-${spool.id}
but it's somewhat not known to the user.Some pictures in dark and light modes.