Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] text 기반 게시물 검색 api 개발 #9

Merged
merged 13 commits into from
Dec 29, 2023
Merged

Conversation

RyuKwanKon
Copy link
Contributor

Related Issue 🪢

Summary 🌿

  • text 기반 게시물 검색 api를 개발했습니다.
  • querydsl을 사용하기 위해 config로 Bean을 등록했습니다.
  • querydsl에서 필요한 데이터를 조회하기 위해 사용되는 dto는 support package로 관리하였습니다.

Before i request PR review 🧤

  • querydsl에서 필요한 dto는 dto 하위 package중 support에서 관리하면 될 것 같습니다.

@RyuKwanKon RyuKwanKon added the FEAT 새로운 기능을 추가 label Dec 28, 2023
@RyuKwanKon RyuKwanKon self-assigned this Dec 28, 2023
Copy link
Contributor

@OJOJIN OJOJIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

.collect(Collectors.toList());
}

private int getAccuracy(PostCheckList postCheckList, CheckList checkList) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정확도 구하는 부분에서
image
이런식으로 음주의 경우 안마심. 2~3회, 4~5회 이런식으로 있는데 내가 4~5회로 체크했다고 가정할 때
"안마심" 과 "2~3회" 체크한 게시물 두개 모두 정확도를 해당 부부분에서 0점을 가져가는게 맞을지 고민이 됩니다. 너무 복잡해지려나요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빈도에 해당하는 checklist의 정확도를 측정하는 로직을 최신화했습니다. 의견주시고 확인하시면 resolve conversation 눌러주세요

Copy link
Member

@ziiyouth ziiyouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!!

Copy link
Contributor

@OJOJIN OJOJIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가적인 코멘트 남겼습니다! 확인 부탁드려요

@RyuKwanKon RyuKwanKon merged commit f104f04 into develop Dec 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT 새로운 기능을 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] text 기반 게시물 검색 api 개발
3 participants