Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 학과정보 #52

Merged
merged 5 commits into from
Jan 17, 2024
Merged

[feat] 학과정보 #52

merged 5 commits into from
Jan 17, 2024

Conversation

OJOJIN
Copy link
Contributor

@OJOJIN OJOJIN commented Jan 16, 2024 •
edited
Loading

Related Issue 🪢

Summary 🌿

  • 학과 정보를 DB에 저장하고 불러오는 API를 만들었습니다.

Before i request PR review 🧤

  • 현재 검색 쿼리를 contains로 요청을 보내서 초성검색이나 이런게 안되고 정확한 단어를 보내야 검색되는데 추후.. 리펙토링으로 개선을 하는게 좋을까요

@OJOJIN OJOJIN added the FEAT 새로운 기능을 추가 label Jan 16, 2024
@OJOJIN OJOJIN requested review from RyuKwanKon and ziiyouth January 16, 2024 10:08
@OJOJIN OJOJIN self-assigned this Jan 16, 2024
RyuKwanKon
RyuKwanKon approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@RyuKwanKon RyuKwanKon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

람따봉

ziiyouth
ziiyouth approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@ziiyouth ziiyouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

@OJOJIN OJOJIN merged commit b9e926f into develop Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziiyouth ziiyouth ziiyouth approved these changes

@RyuKwanKon RyuKwanKon RyuKwanKon approved these changes

Assignees

@OJOJIN OJOJIN

Labels
FEAT 새로운 기능을 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 학과정보
3 participants
@OJOJIN @RyuKwanKon @ziiyouth