Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 게시글 작성 api 구현 #26

Merged
merged 12 commits into from
Jan 6, 2024
Merged

[feat] 게시글 작성 api 구현 #26

merged 12 commits into from
Jan 6, 2024

Conversation

RyuKwanKon
Copy link
Contributor

@RyuKwanKon RyuKwanKon commented Jan 6, 2024 •
edited
Loading

Related Issue 🪢

Summary 🌿

  • 게시글 작성 api를 구현했습니다.
  • 기본 request dto에 valid로직을 추가해서 BindException으로 예외를 잡았습니다.
  • 비즈니스로직 예외로 중복된 제목 정도만 잡았습니다.

Before i request PR review 🧤

  • 음 적당한 비즈니스 로직 중 예외를 잡을게 있을까요?

@RyuKwanKon RyuKwanKon added the FEAT 새로운 기능을 추가 label Jan 6, 2024
@RyuKwanKon RyuKwanKon requested review from OJOJIN and ziiyouth January 6, 2024 08:54
@RyuKwanKon RyuKwanKon self-assigned this Jan 6, 2024
OJOJIN
OJOJIN approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@OJOJIN OJOJIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다👍
지금처럼 제목만 잡아줘도 괜찮을 것 같아요

ziiyouth
ziiyouth approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@ziiyouth ziiyouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 고생하셨습니다~~

src/main/java/org/gachon/checkmate/domain/post/service/PostService.java Show resolved Hide resolved
@RyuKwanKon RyuKwanKon merged commit 8c55b8d into develop Jan 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziiyouth ziiyouth ziiyouth approved these changes

@OJOJIN OJOJIN OJOJIN approved these changes

Assignees

@RyuKwanKon RyuKwanKon

Labels
FEAT 새로운 기능을 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 게시글 작성 api 구현
3 participants
@RyuKwanKon @OJOJIN @ziiyouth