Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] keyword 중심 search 정렬 기준 반영 #16

Merged
merged 6 commits into from
Jan 3, 2024
Merged

[fix] keyword 중심 search 정렬 기준 반영 #16

merged 6 commits into from
Jan 3, 2024

Conversation

RyuKwanKon
Copy link
Contributor

Related Issue 🪢

Summary 🌿

  • keyword 중심 search 정렬 기준 반영
  • paging 의존성을 쿼리에서 service단으로 분리
  • 최신 등록일자를 default로 쿼리 검색 진행
  • 각 검색 조건에 맞는 정렬 기준으로 정렬 O(n log n) 시간 복잡도 사용
  • custom paging util을 구현하여 paging을 사용

Before i request PR review 🧤

  • 오타 찾아주세요

@RyuKwanKon RyuKwanKon added FEAT 새로운 기능을 추가 FIX 코드 버그 수정 labels Jan 3, 2024
@RyuKwanKon RyuKwanKon requested review from OJOJIN and ziiyouth January 3, 2024 11:20
@RyuKwanKon RyuKwanKon self-assigned this Jan 3, 2024
OJOJIN
OJOJIN reviewed Jan 3, 2024
View reviewed changes
Copy link
Contributor

@OJOJIN OJOJIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 코멘트 남겼습니다.

src/main/java/org/gachon/checkmate/domain/post/repository/PostQuerydslRepository.java Show resolved Hide resolved
ziiyouth
ziiyouth approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@ziiyouth ziiyouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니돠아

src/main/java/org/gachon/checkmate/global/utils/PagingUtils.java Show resolved Hide resolved
@RyuKwanKon RyuKwanKon merged commit 7acb591 into develop Jan 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OJOJIN OJOJIN OJOJIN approved these changes

@ziiyouth ziiyouth ziiyouth approved these changes

Assignees

@RyuKwanKon RyuKwanKon

Labels
FEAT 새로운 기능을 추가 FIX 코드 버그 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] keyword 중심 search 정렬 기준 반영
3 participants
@RyuKwanKon @OJOJIN @ziiyouth