Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add db tables for product attribute variant #31221

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

frederic34
Copy link
Member

No description provided.

@@ -0,0 +1,19 @@
-- ===================================================================
Copy link
Member

@eldy eldy Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to rename the table into
llx_product_attribute_extrafields so the table will be create only if we activate the module variant.

Same for all other tables.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the table or the file ?
llx_product_attribute_extrafields.sql to llx_product_attribute_extrafields-variants.sql

@eldy eldy added the PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants