Fix php8 change, '' != 0 since php8 #30997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Since PHP8 '' != 0 which change the behavior on dispatch.
Pre PHP8 when you don't fill a quantity it was accepted as 0 and don't check if a warehouse is set
On develop, you use a new function GETPOSTFLOAT which use (float) price2num GETPOST and since there is a cast to float, the empty string become a 0, it has the same reaction as pre PHP8
But here on dolibarr V18, there is no GETPOSTFLOAT or anything to change the empty string to 0, and it goes inside the "if" and return an error if a warehouse is not set
To prevent this change of behavior, I just added a check !empty(GETPOST($qty))