Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX late order search option (v18+) #30692

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

W1W1-M
Copy link
Contributor

@W1W1-M W1W1-M commented Aug 20, 2024

FIX late order search option (v18+)

Like invoices #30670, the home page link to late orders does not work correctly. Currently the link will open the order list with all validated+in process orders, the late alert duration is not used.
This PR adds a search_option post variable & url_late for the home page link as well as a alert checkbox on the order list.

fix-late-order-list
fix-late-order-list-alert

Associated issues: #25963 #26056

@eldy eldy added the Pending analysis of PR (maintenance team) PR is in a maintenance branch with several approvers. Waiting approval of all of them. label Aug 20, 2024
@lvessiller-opendsi
Copy link
Contributor

Could you separate the FIX content and NEW content into 2 PRs ? (one on 18.0 and one on develop)

@lvessiller-opendsi
Copy link
Contributor

@rycks
it's ok for me

@eldy eldy requested a review from rycks September 9, 2024 02:31
Copy link
Contributor

@rycks rycks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@eldy eldy merged commit 1a81d7f into Dolibarr:18.0 Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending analysis of PR (maintenance team) PR is in a maintenance branch with several approvers. Waiting approval of all of them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants