FIX #30670 late invoice search option (v19) #30674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W1W1-M
changed the title
|
@W1W1-M you change just the name of variable ! Where is the broken feature? |
I also changed the key used in GETPOST. I changed the variable name in order to comply with clean code principles, the rest of the code base and also the fix that already exists in v21. |
|
@W1W1-M sorry but, how will the name change correct a broken feature here? |
Ah, unless I'm mistaken the menu link from home page is using search_option and not search_late for the post variable. Hope this clears things up 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #30670 late invoice search option (v19)
Fixes broken search option for late invoices