FIX Accountancy - Blocking on annual closing #30653
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Aug 16, 2024
| @@ -2707,7 +2715,7 @@ public function closeFiscalPeriod($fiscal_period_id, $new_fiscal_period_id, $sep | |||
| $sql .= ' AND aa.pcg_type IN (' . $this->db->sanitize(implode(',', $pcg_type_filter), 1) . ')'; | |||
| $sql .= " AND DATE(t.doc_date) >= '" . $this->db->idate($fiscal_period->date_start) . "'"; | |||
| $sql .= " AND DATE(t.doc_date) <= '" . $this->db->idate($fiscal_period->date_end) . "'"; | |||
| $sql .= ' GROUP BY t.numero_compte, t.label_compte, aa.pcg_type'; | |||
| $sql .= ' GROUP BY t.numero_compte, aa.pcg_type'; | |||
There was a problem hiding this comment.
Imagine you have in database
1 line: account = 12345, label = 'A label for the transaction", amount 10
1 line: account = 12345, label = 'A different transaction', amount 15
What do we want after creating the "A nouveau" lines ?
Just 1 line with amount 25 and label = 'A nouveau for closure abc' ?
Can you confirm ?
There was a problem hiding this comment.
I can confirm that this is exactly what we're aiming for. It's the a-nouveaux principle.
The a-nouveaux entry is similar to a trial balance in reality.
In France, this consists of summarizing all class 1 to 5 accounts (CAPIT to FINAN) in a single account.
And the annual result class 7 - 6 (INCOME - EXPENSE) goes to account 120 or 129.
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix related to this forum post : https://www.dolibarr.fr/forum/t/cloture-exercice-et-a-nouveau/47070
If an account is used with an other label, the closure is impossible.
Need feedback