restored value __REF__ #30607
restored value __REF__ #30607
Conversation
| $topicmail = $outputlangs->trans($defaulttopic, '__REF__'); | ||
| } elseif (!empty($object->ref_client)) { | ||
| $topicmail = $outputlangs->trans($defaulttopic, '__REF__ (__REF_CLIENT__)'); |
There was a problem hiding this comment.
Why removing this ?
Can you describe how to reproduce the bug ?
There was a problem hiding this comment.
There are no bugs
When you use the subtitution key ‘__REF__’ and you have filled in the ‘ref_client’ field in the interface, this field is concatenated with __REF__ in the email subject, which gives :
__REF__ (__REF_CLIENT__)
But at no time in the email template did we call the subtitution key __REF_CLIENT__.
Concatenation is imposed by the code.
If the user absolutely wanted to see the ref_client field in the subject line of their email, they could always add the __REF_CLIENT__ subtitution key in the subject line of their email template.
I just want that when we use __REF__ we display what corresponds to the __REF__ and don't concatenate anything.
There was a problem hiding this comment.
To reproduce this behaviour, simply use an email template with the key __REF__ in the subject line.
There was a problem hiding this comment.
To reproduce this behaviour, simply use an email template with the key
__REF__in the subject line.
I do not succeed in reproducing the problem. I created an email template with REF as topic. When I send an email from a proposal P1 and ref_client PC1, after selecting the email template, the topic is set to P1 as expected.
There was a problem hiding this comment.
I made a mistake.
To reproduce, you don't need to use an email template.
There was a problem hiding this comment.
I made a mistake. To reproduce, you don't need to use an email template.
So how did you do ?
There was a problem hiding this comment.
I have a customer who wants only their reference in the subject, without including the customer reference, even if the customer reference is set. How can we properly fix this?
There was a problem hiding this comment.
If user don't want the default email autofill behaviour, he can set its own email template and set it as default.
There was a problem hiding this comment.
OK, so that's how we're going to do it
Thanks anyway
eldy
added
Bug or PR need more information
Instructions
FIX To restore the value of the REF key, the user can still use REF_CLIENT in an email template.