-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport Fix error on empty(NOLOGIN) #30594
Merged
eldy
merged 6 commits into
Dolibarr:18.0
from
MaximilienR-easya:18.0_Backport_fix_from_develop
Sep 23, 2024
Merged
Backport Fix error on empty(NOLOGIN) #30594
eldy
merged 6 commits into
Dolibarr:18.0
from
MaximilienR-easya:18.0_Backport_fix_from_develop
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvessiller-opendsi
approved these changes
Aug 12, 2024
@rycks |
eldy
added
the
Pending analysis of PR (maintenance team)
PR is in a maintenance branch with several approvers. Waiting approval of all of them.
label
Aug 14, 2024
rycks
reviewed
Sep 5, 2024
htdocs/core/triggers/interface_20_modWorkflow_WorkflowManager.class.php
Outdated
Show resolved
Hide resolved
rycks
reviewed
Sep 5, 2024
rycks
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Pending analysis of PR (maintenance team)
PR is in a maintenance branch with several approvers. Waiting approval of all of them.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Backport Fix from develop
empty(NOLOGIN) is causing an error since PHP8.
Doing the backport, i have taken the opportunity to backport some change from [#26365] and [#26608]