Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Fix error on empty(NOLOGIN) #30594

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

MaximilienR-easya
Copy link
Contributor

@MaximilienR-easya MaximilienR-easya commented Aug 9, 2024

Fix

Backport Fix from develop
empty(NOLOGIN) is causing an error since PHP8.
Doing the backport, i have taken the opportunity to backport some change from [#26365] and [#26608]

@lvessiller-opendsi
Copy link
Contributor

@rycks
It's ok for me

@eldy eldy added the Pending analysis of PR (maintenance team) PR is in a maintenance branch with several approvers. Waiting approval of all of them. label Aug 14, 2024
Copy link
Contributor

@rycks rycks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me

@eldy eldy merged commit fd0338c into Dolibarr:18.0 Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending analysis of PR (maintenance team) PR is in a maintenance branch with several approvers. Waiting approval of all of them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants