fix imports #30436
fix imports #30436
Conversation
| @@ -929,9 +929,9 @@ public function import_insert($arrayrecord, $array_match_file_to_database, $obji | |||
| // Note: For extrafield tablename, we have in importfieldshidden_array an enty 'extra.fk_object'=>'lastrowid-tableparent' so $keyfield is 'fk_object' | |||
| $sqlSelect = "SELECT rowid FROM ".$tablename; | |||
|
|
|||
| if (empty($keyfield)) { | |||
| //if (empty($keyfield)) { keyfield may content any hidden update field !!! | |||
There was a problem hiding this comment.
Which value of keyfield did yo get.
Also can you describe the process to reproduce the bug with example of selected/entered values ?
Do you experience the trouble in v19 ?
eldy
added
PR waiting more user feedbacks
|
@altairis-tof i need more informations too ... for information in 20.0 you seems to made a different fix : #29553 no ? and in case of fix for that bug, i think xls import will be concerned too @eldy could a backport of 20.0 fix be a better solution in same situation ? |
@rycks Yes, if a bug is already fixed in a higher version, a fix for a backport should use the same way to fix than the fix in higher version. It is always a better solution, as long as it is possible. This may not be possible if backport/cherry-pick is not possible because the fix in recent version is based on other changes done by other PR available only into the recent version. |
|
@altairis-tof what do you think about that ? different solution with #29553 looks strange and make me trouble ... |
keyfield may content any field defined in import_fieldshidden_array so the present code dont do updates !