FIX #30397: for direct debit payments, BIC is optional #30398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Jul 16, 2024
eldy
reviewed
Jul 16, 2024
eldy
added
the
PR to fix or conflict to solve
priojk
added a commit
to priojk/dolibarr
that referenced
this pull request
Jul 19, 2024
If no BIC is provided, only the BIC line must be omitted, not the surrounding block, even if it is empty.
eldy
pushed a commit
that referenced
this pull request
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to SWIFT regulations for direct debit payments, IBAN is sufficient information and the BIC code is optional. But Dolibarr is rejecting the creation of direct debit payments without BIC code (see Issue #30397).
The code adjusts the behaviour of Dolibarr and allows the creation of direct debit payment xml-files based only on the customer IBAN (for the time being, only if the variable WITHDRAWALS_WITHOUT_BIC is set, in order not to interfere with existing installations).