Fix & Enable PhanTypeInvalidPropertyName #29037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeweerd
force-pushed
the
fix/PhanTypeInvalidPropertyName
branch
4 times, most recently
from
23705de
to
913b89d
Compare
mdeweerd
changed the title
mdeweerd
force-pushed
the
fix/PhanTypeInvalidPropertyName
branch
3 times, most recently
from
d4c6daf
to
7f5dc89
Compare
mdeweerd
force-pushed
the
fix/PhanTypeInvalidPropertyName
branch
from
299eac7
to
96d1f25
Compare
mdeweerd
force-pushed
the
fix/PhanTypeInvalidPropertyName
branch
from
96d1f25
to
f357056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix & Enable PhanTypeInvalidPropertyName
This PR fixes several PhanTypeInvalidPropertyName occurences, except the follwoing.
htdocs\comm\mailing\class\html.formadvtargetemailing.class.php
There is a test
empty($InfoFieldList[1])suggesting that this field can be empty, but it is then used untested as a property name - strange.pdf_ classes
The
$arrayidcontact = $object->$origin->getIdContact('external', 'SHIPPING');assignments in the pdf_* classes were not fixed.It seems that this assignment should be avoided: it seems to be done already once earlier in the method and IMHO the
$arrayidcontactvalue should be reused as the first assignement qualifies that $object->$origin is an object, where the second assignement does not.However, I prefer that a person with more dolibarr experience checks that out.
(Apart from the above, the PhanTypeInvalidPropertyName are fixed.