-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX - Add condition to delete product #27424
Closed
atm-lucasmantegari
wants to merge
4,143
commits into
Dolibarr:18.0
from
atm-lucasmantegari:FIX_DeleteProductBOM
Closed
FIX - Add condition to delete product #27424
atm-lucasmantegari
wants to merge
4,143
commits into
Dolibarr:18.0
from
atm-lucasmantegari:FIX_DeleteProductBOM
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@eldy I think Travis has a bug. If not, please explain to me |
eldy
reviewed
Jan 12, 2024
eldy
added
the
PR to fix or conflict to solve
PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
label
Jan 12, 2024
FIX : MRP divide product not working
BugFix Autocomplete under dialog box
FIX empty array with php8.2
Fix php error in cronjob.class.php
…" is true (Dolibarr#30181) * Fix: Api MRP ProduceAndConsume if MoLine option "disable_stock_change" is true. * fix typo
See my first comment.. |
See f401ad5 |
* Unknown Character * Add replace on dol_htmlwithnojs
…0404) * add external contact with billing code in supplier_proposal pdf * update with pr returns * Update pdf_other.php * fix inversing condition * Update pdf_other.php --------- Co-authored-by: Laurent Destailleur <[email protected]>
@eldy its better like this ? |
Seems better. But have cti errors |
eldy
added
PR to fix or conflict to solve
PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
and removed
Discussion
Some questions or discussions are opened and wait answers of author or other people to be processed
labels
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR to fix or conflict to solve
PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX - Add condition to delete product
We can currently delete a product even though it is in a BOM.
Adding this check helps avoid an SQL error when using this product on a OF.