Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.0.0 #8

Merged
merged 3 commits into from
May 10, 2024
Merged

Version 1.0.0 #8

merged 3 commits into from
May 10, 2024

Conversation

FabienLavocat
Copy link
Member

  • Remove the default export for SDK entry point. The WebRTCStats class needs to be imported this way:
import { WebRTCStats } from '@dolbyio/webrtc-stats';
  • Add documentation
  • Update definitions

@FabienLavocat FabienLavocat self-assigned this May 10, 2024
@j12y j12y self-requested a review May 10, 2024 21:05
j12y
j12y approved these changes May 10, 2024
View reviewed changes
Copy link

@j12y j12y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, code looks fine

pulled it down locally to test and was seeing stats events fire and looks good to me

@FabienLavocat FabienLavocat merged commit 39451b4 into main May 10, 2024
4 checks passed
@FabienLavocat FabienLavocat deleted the docs branch May 10, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j12y j12y j12y approved these changes

Assignees

@FabienLavocat FabienLavocat

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabienLavocat @j12y