#1117 Fix incorrectly configured scope bounds for Javadoc Checkstyle checks

[GuusLieben]

Type of Change

• Documentation (documentation changes)
• Chore (changes to the build process or auxiliary tools)

Description

The checkstyle.xml configuration in hartshorn-assembly incorrectly uses excludeScope. The value of excludeScope applies to the scope property, which defaults to public (instead of our assumption to include all by default). Following https://checkstyle.sourceforge.io/property_types.html#Scope, this means only public is checked, while package-private, protected, private, and anonymous inner classes are always skipped.

These changes fix this issue by correctly setting up the scope boundaries of the configuration. Additionally, pending documentation is included in this PR, to ensure CI passes going forward.

Checklist

• I have performed a self-review of my own code
• New and existing unit tests pass locally with my changes
• Related issue number is linked in pull request title
• I have added documentation that describes my changes
• Any dependent changes have been merged and published in downstream modules
• I have rebased my branch on top of the latest develop branch

Related Issue

Closes #1117